[expo-sms] Adds Attachment Support To Add Images To SMS Messages #7967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorbenprimke
changed the title
thorbenprimke
changed the title
thorbenprimke
force-pushed
the
tp-sms-adds-attachment
branch
from
4c355dc
to
ef5e254
Compare
EvanBacon
reviewed
Apr 23, 2020
EvanBacon
reviewed
Apr 23, 2020
EvanBacon
reviewed
Apr 23, 2020
bbarthec
reviewed
Apr 24, 2020
thorbenprimke
force-pushed
the
tp-sms-adds-attachment
branch
from
ef5e254
to
3103f14
Compare
thorbenprimke
commented
Apr 24, 2020
Comment on lines
+38
to
+45
| remoteUri: 'https://upload.wikimedia.org/wikipedia/commons/2/2c/Rotating_earth_%28large%29.gif', | ||
| md5: '090592ebd01ac1e425b2766989040f80', | ||
| mimeType: 'image/gif', | ||
| }; | ||
|
|
||
| const audioFile = { | ||
| localUri: FS.documentDirectory + 'sound.mp3', | ||
| remoteUri: 'https://dl.espressif.com/dl/audio/gs-16b-1c-44100hz.mp3', |
There was a problem hiding this comment.
@EvanBacon @bbarthec - would one of y'all be able to upload these to the test-suite-data S3 bucket?
There was a problem hiding this comment.
I can change after merged
thorbenprimke
commented
Apr 24, 2020
thorbenprimke
force-pushed
the
tp-sms-adds-attachment
branch
from
3103f14
to
e2d71a3
Compare
|
Updated to wrap the |
EvanBacon
reviewed
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The Expo SMS package currently does not support image attachments.
How
Adds support for both iOS and Android to share an image attachment (png or jpeg) alongside the message.
Note: I would appreciate any feedback on this. If you are open to merging this in, I'll update the documentation as well.
Test Plan
Added tests to both iOS and Android test suite to validate the functionality.